[SourceKit] Enable PrettyStackTrace printing #17205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this will result in PrettyStackTrace messages being included in crash logs when SourceKit crashes on Apple platforms.
|
@swift-ci Please test |
|
This should go in the call_once block inside |
|
I tried that and it didn't work. Are signal-handlers per-thread? |
|
…no. But maybe it needs to get run after dispatch_initialize or whatever. …I'm really not sure why it makes a difference, but it does seem to. |
|
Argh, of course. sourcekitd_initialize is running in the client, not the service. Don't mind me. Where you have it seems fine. |
|
Any concerns about cherry-picking this to the 4.2 branch? It should only have an effect when the process was going to crash anyway. |
benlangmuir
approved these changes
Jun 14, 2018
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 14, 2018
In particular, this will result in PrettyStackTrace messages being included in crash logs when SourceKit crashes on Apple platforms. (cherry picked from commit fb8c815)
jrose-apple
added a commit
that referenced
this pull request
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this will result in PrettyStackTrace messages being included in crash logs when SourceKit crashes on Apple platforms.