Skip to content

[4.2-06-11] Only disable Network test on watchOS #17215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2018
Merged

[4.2-06-11] Only disable Network test on watchOS #17215

merged 1 commit into from
Jun 15, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jun 14, 2018

Similar to #17204

  • Explanation: In order to have some coverage of Network overlay, the test should run. We don’t build Network for watchOS so it’s OK to disable it for watchOS only.
  • Risk: Minimal
  • Reviewed By: Mishal Shah
  • Testing: Automated test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/40799651

@moiseev
Copy link
Contributor Author

moiseev commented Jun 14, 2018

@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Jun 14, 2018

@swift-ci Please nominate

@moiseev moiseev requested a review from shahmishal June 14, 2018 20:46
shahmishal
shahmishal approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@moiseev moiseev merged commit 865c8de into swift-4.2-branch-06-11-2018 Jun 15, 2018
@moiseev moiseev deleted the network-test-4.2-06-11 branch June 15, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moiseev @shahmishal