Skip to content

[swift-4.2-branch-06-11-2018] emit sigint for cancelled batch constituents #17233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2018
Merged

[swift-4.2-branch-06-11-2018] emit sigint for cancelled batch constituents #17233

merged 4 commits into from
Jun 15, 2018

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Jun 15, 2018 •
edited
Loading

swift-4.2-branch-06-11-2018 cherry-pick of #17167, #17228 and #17131

  • Explanation: Allow cancelling (via simulated SIGINT) batch-mode constituent jobs that were batched together with jobs that had errors. Swift side of eliminating the nonspecific error "compilation stopped by errors in other files", when a file has an error in batch-mode.
  • Scope: The nonspecific error was being emitted for all files in a batch that did not contain an error, whenever some other file in the batch did contain an error. This caused a lot of noise in issue and report navigator any time any file had an error.
  • Risk: Low-ish. Only affects diagnostic reporting at the driver level, and only reverts an obnoxious artificial case and re-encodes it in a way that permits suppressing the situation altogether.
  • Reviewed by: Jordan Rose, David Ungar.

rdar://41164520

@graydon graydon force-pushed the rdar-40526328-emit-SIGINT-for-cancelled-batch-constituents-swift-4.2-branch-06-11-2018 branch from f047554 to db35e85 Compare June 15, 2018 04:58
@graydon graydon changed the title Rdar 40526328 emit sigint for cancelled batch constituents swift 4.2 branch 06 11 2018 [swift-4.2-branch-06-11-2018] emit sigint for cancelled batch constituents Jun 15, 2018
@graydon
Copy link
Contributor Author

graydon commented Jun 15, 2018

@swift-ci please test

@graydon
Copy link
Contributor Author

graydon commented Jun 15, 2018

@swift-ci please nominate

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - db35e85

@graydon
Copy link
Contributor Author

graydon commented Jun 15, 2018

@swift-ci please test OSX Platform

1 similar comment
@graydon
Copy link
Contributor Author

graydon commented Jun 15, 2018

@swift-ci please test OSX Platform

@graydon
Copy link
Contributor Author

graydon commented Jun 15, 2018

@swift-ci please test macos platform

@AnnaZaks
Copy link
Contributor

@swift-ci please nominate

1 similar comment
@najacque
Copy link
Contributor

@swift-ci please nominate

@graydon graydon merged commit 876917f into swiftlang:swift-4.2-branch-06-11-2018 Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@graydon @swift-ci @AnnaZaks @najacque @davidungar