Fix a bunch of performance issues in Function Signature Optimizations #17234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
…an ArrayRef instead. I don't think I need to say more here. rdar://41146023
…alue. This is particularly egrigious since we are only /reading/ from the DenseSet. So we are basically mallocing/copying a DenseSet just to read from it... I don't think I need to say more. rdar://41146023
gottesmm
force-pushed
the
pr-0e0ac4897be5b6059f2959956c708dea2e027b88
branch
from
aa9c531 to
369b1f4
Compare
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bunch of pretty bad performance problems in Function Signature Optimizations. Not going to say how they got here... but I am going to fix them real quick.
Specifically we were copying around ADTs just to read them. There is no excuse for that.
rdar://41146023