Access control improvements #17252
Merged
Access control improvements #17252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap verification errors
The various 'isExplicit' checks were wrong -- they should apply to protocol requirements only, not protocol extension members. Also, we weren't performing this check for type aliases in protocols, so you would get a misleading diagnostic telling you the type alias must be declared private/internal, when in fact type aliases in protocols cannot have their own access control. Finally, the "should be declared <X>" diagnostics (the !isExplicit case) need to state the most visible access level that will work, and in a few cases we would say private instead of fileprivate here.
…ated types We weren't checking this before, which would let you define a public protocol that no public type could conform to. This is a source-breaking change, so stage it in with a warning. It becomes an error in -swift-version 5 mode.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
privatevsfileprivateThis is just landing a piece of #16586.