[ClangImporter] Handle lookup tables with many entries #17265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, there are frameworks with more than 65536 entries for 'init' as a base name. I can't think of a test case for this besides actually adding such a massive framework, but the assertions that were added here should catch the issue in Debug builds if it ever comes up again. I'm going to go harden everything else that uses this API next. rdar://problem/40828315
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
ahoppen
approved these changes
Jun 15, 2018
DougGregor
reviewed
Jun 16, 2018
|
|
||
| // # of entries | ||
| uint32_t dataLength = | ||
| sizeof(uint16_t) + sizeof(uint64_t) * data.size(); | ||
| assert(dataLength == static_cast<uint16_t>(dataLength)); |
There was a problem hiding this comment.
Shouldn’t this be checking against uint32_t?
There was a problem hiding this comment.
No, this is a different table, which I didn't change.
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 18, 2018
In particular, there are frameworks with more than 65536 entries for 'init' as a base name. I can't think of a test case for this besides actually adding such a massive framework, but the assertions that were added here should catch the issue in Debug builds if it ever comes up again. I'm going to go harden everything else that uses this API next. rdar://problem/40828315 (cherry picked from commit 864bf89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, there are frameworks with more than 65536 entries for
initas a base name.I can't think of a test case for this besides actually adding such a massive framework, but the assertions that were added here should catch the issue in Debug builds if it ever comes up again. I'm going to go harden everything else that uses this API next (
llvm::endian::Writer).rdar://problem/40828315