[Request-evaluator] Improve debuggability #17277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print out the stack of requests being evaluated when we crash, so we can see the dependency chain the triggered the crash.
As a debugging aid, introduce a new frontend flag `-debug-cycles` that will emit a debug dump whenever the request-evaluator encounters a cyclic dependency, while otherwise allowing compilation to continue.
When dumping dependencies, clean up the output in two ways: * Elide redundant but (non-cyclic) references to the same dependency. * When dumping a cycle, highlight the path to the cycle so it stands out.
DougGregor
force-pushed
the
evaluator-debug-cycle-diags
branch
from
37f7fc1 to
7bf8623
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve debuggability of the request-evaluator:
-debug-cyclesfrontend option to dump cycles when we encounter them (without affecting type checking behavior)