[NFC] Separate FunctionTypeRepr Input Resolution #17279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract param resolution of FunctionTypeReprs and greatly simpify TupleTypeRepr resolution.
This only really existed to support reinterpreting TupleTypeRepr as a function parameter. Now that we're doing that separately it is useless.
CodaFi
force-pushed
the
parametric-monomorphism
branch
from
7cc35a5 to
e60bbd4
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract function parameter resolution as a separate kind of operation in TypeCheckType. This greatly simplifies the
TupleTypeReprresolution case and moves us closer to a world where we can drop theParameterTypeFlagsout ofTupleTypeElt.