Skip to content

[CodeCompletion] Resolve witnesses when conformance in different file to avoid dups #17288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2018
Merged

[CodeCompletion] Resolve witnesses when conformance in different file to avoid dups #17288

merged 1 commit into from
Jun 27, 2018

Conversation

AnthonyLatsis
Copy link
Collaborator

Resolves SR-7225.

@AnthonyLatsis AnthonyLatsis changed the title [CodeCompletion] resolve witnesses when conformance in different file to avoid dups [CodeCompletion] Resolve witnesses when conformance in different file to avoid dups Jun 18, 2018
@jrose-apple jrose-apple requested a review from DougGregor June 18, 2018 18:17
@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Jun 18, 2018 •
edited
Loading

cc @benlangmuir @nkcsgexi

Edit Oops, didn't notice Jordan already requested a review.

@benlangmuir
Copy link
Contributor

I'm probably not the right person to review this; @DougGregor or @slavapestov, could you take a look?

@jrose-apple
Copy link
Contributor

Doug's actually out right now, so it may be a few days.

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Jun 19, 2018 •
edited
Loading

Hopefully Slava will take a glance.

@AnthonyLatsis
Copy link
Collaborator Author

@DougGregor, have a couple of minutes?

@DougGregor
Copy link
Member

@swift-ci please smoke test

DougGregor
DougGregor approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, LGTM. This is the current correct way to perform filtering.

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Jun 25, 2018 •
edited
Loading

⛵️?

@AnnaZaks AnnaZaks merged commit b2fb118 into swiftlang:master Jun 27, 2018
@AnthonyLatsis
Copy link
Collaborator Author

Thanks, Anna.

@AnthonyLatsis AnthonyLatsis deleted the multifile-code-compl-fix-witness-and-req-shown branch February 17, 2022 21:04
@AnthonyLatsis AnthonyLatsis mentioned this pull request Jun 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnthonyLatsis @benlangmuir @jrose-apple @DougGregor @AnnaZaks