Skip to content

[stdlib] Add @usableFromInline to internal typealiases that need it #17296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Jun 18, 2018

This fixes 3659 issues in the standard library, uncovered by @slavapestov's change in #17257

This fixes 3659 warnings in the standard library.
@lorentey
Copy link
Member Author

@swift-ci please smoke test

@lorentey lorentey requested a review from slavapestov June 18, 2018 15:45
@lorentey
Copy link
Member Author

@swift-ci please clean smoke test macOS platform

@milseman
Copy link
Member

@swift-ci please smoke test compiler performance

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully there's not a large code size cost to the stdlib.

@slavapestov
Copy link
Contributor

There should not be a code size cost at all. I already had this change in another PR, I forgot to land it, sorry!

@slavapestov
Copy link
Contributor

@lorentey You can merge this change. It will have no effect on compiler performance

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 36,543,344 36,543,546 202 0.0%
time.swift-driver.wall 70.0s 69.6s -461.6ms -0.66%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 82,886 82,886 0 0.0%
AST.NumLoadedModules 12,485 12,485 0 0.0%
AST.NumTotalClangImportedEntities 253,783 253,783 0 0.0%
AST.NumUsedConformances 8,764 8,764 0 0.0%
IRModule.NumIRBasicBlocks 127,596 127,596 0 0.0%
IRModule.NumIRFunctions 75,854 75,854 0 0.0%
IRModule.NumIRGlobals 69,304 69,304 0 0.0%
IRModule.NumIRInsts 1,426,333 1,426,333 0 0.0%
IRModule.NumIRValueSymbols 129,870 129,870 0 0.0%
LLVM.NumLLVMBytesOutput 36,543,344 36,543,546 202 0.0%
SILModule.NumSILGenFunctions 44,348 44,348 0 0.0%
SILModule.NumSILOptFunctions 47,339 47,339 0 0.0%
Sema.NumConformancesDeserialized 351,426 351,426 0 0.0%
Sema.NumConstraintScopes 917,295 917,295 0 0.0%
Sema.NumDeclsDeserialized 2,072,980 2,072,980 0 0.0%
Sema.NumDeclsValidated 188,816 188,816 0 0.0%
Sema.NumFunctionsTypechecked 47,175 47,175 0 0.0%
Sema.NumGenericSignatureBuilders 80,130 80,130 0 0.0%
Sema.NumLazyGenericEnvironments 415,282 415,282 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 38,122 38,122 0 0.0%
Sema.NumLazyIterableDeclContexts 332,013 332,013 0 0.0%
Sema.NumTypesDeserialized 2,286,652 2,286,652 0 0.0%
Sema.NumTypesValidated 160,444 160,444 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 26,904,276 26,904,260 -16 -0.0%
time.swift-driver.wall 144.3s 143.9s -418.4ms -0.29%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 8,857 8,857 0 0.0%
AST.NumLoadedModules 408 408 0 0.0%
AST.NumTotalClangImportedEntities 25,770 25,770 0 0.0%
AST.NumUsedConformances 8,770 8,770 0 0.0%
IRModule.NumIRBasicBlocks 151,572 151,572 0 0.0%
IRModule.NumIRFunctions 56,857 56,857 0 0.0%
IRModule.NumIRGlobals 54,176 54,176 0 0.0%
IRModule.NumIRInsts 1,239,602 1,239,602 0 0.0%
IRModule.NumIRValueSymbols 101,771 101,771 0 0.0%
LLVM.NumLLVMBytesOutput 26,904,276 26,904,260 -16 -0.0%
SILModule.NumSILGenFunctions 22,181 22,181 0 0.0%
SILModule.NumSILOptFunctions 35,950 35,950 0 0.0%
Sema.NumConformancesDeserialized 86,099 86,099 0 0.0%
Sema.NumConstraintScopes 815,756 815,756 0 0.0%
Sema.NumDeclsDeserialized 205,259 205,259 0 0.0%
Sema.NumDeclsValidated 59,866 59,866 0 0.0%
Sema.NumFunctionsTypechecked 10,716 10,716 0 0.0%
Sema.NumGenericSignatureBuilders 9,749 9,749 0 0.0%
Sema.NumLazyGenericEnvironments 32,322 32,322 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 4,556 4,556 0 0.0%
Sema.NumLazyIterableDeclContexts 20,667 20,667 0 0.0%
Sema.NumTypesDeserialized 268,790 268,790 0 0.0%
Sema.NumTypesValidated 33,026 33,026 0 0.0%

@slavapestov slavapestov merged commit 88d305c into swiftlang:master Jun 18, 2018
@lorentey lorentey deleted the usableFromInline-typealiases branch June 19, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants