Restrict RemoteASTTypeBuilder::findModule() to the list of loaded modules #17345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules. LLDB uses RemoteAST for its per-module SwiftASTContext. Importing external modules here could permanently damage this context, for example when a Clang import fails because of missing header search options. To avoid this situation, restrict RemoteAST's access to only the module's transitive closure of imports. Triggering this situation needs two independent Swift compilation units. An accompanying testcase (Swift/RemoteASTImport.test) has been added to LLDB. rdar://problem/40950542
|
test with apple/swift-lldb#704 |
|
test with apple/swift-lldb#704 |
|
This looks correct to me; I'd just like someone within Apple to confirm that this won't mess up anyone else's use of RemoteAST. |
|
If you have anyone specific in mind, please feel free to add more reviewers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLDB uses RemoteAST for its per-module SwiftASTContext. Importing
external modules here could permanently damage this context, for
example when a Clang import fails because of missing header search
options. To avoid this situation, restrict RemoteAST's access to only
the module's transitive closure of imports.
Triggering this situation needs two independent Swift compilation
units. An accompanying testcase (Swift/RemoteASTImport.test) has been
added to LLDB.
rdar://problem/40950542