[ConstraintSystem] Reinstate favoring more specialized of two generic… #17352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overloads. This was originally commited in 3d32e89, and then backed out in c40fd39 due to concern over behavioral changes. This version avoids the optimization when there are any optional types involved in the signatures of the functions. For these cases, compareDeclarations can return the wrong order at the moment. I have another PR in the works that attempts to begin unraveling some of the issues around fixing the overload comparisons.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
DougGregor
approved these changes
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… overloads.
This was originally commited in
3d32e89, and then backed out in
c40fd39 due to concern over
behavioral changes.
This version avoids the optimization when there are any optional types
involved in the signatures of the functions.
For these cases, compareDeclarations can return the wrong order at the
moment.
I have another PR in the works that attempts to begin unraveling some
of the issues around fixing the overload comparisons.
Fixes: rdar://problem/41109953