[4.2 2018-06-11] [Mangling] Mangle more standard substitutions #17358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes. Since the mangling scheme and set of standard library types is effectively fixed now, introduce known mangling substitutions for a number of new standard library types, filling out the S[A-Za-z] space. Reduces standard library binary size by ~195k. (cherry picked from commit 7952a19)
Protocol name mangling didn’t always go through a path that allowed the use of standard substitutions. Enable standard substitutions for protocol name manglings where they make sense. Removes ~277k from the standard library binary size. (cherry picked from commit f232af5)
(cherry picked from commit a66df57)
|
@swift-ci please test |
|
@swift-ci please nominate |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Use more of the "standard substitution" mangling space (
S<character>), for commonly-used standard library types, likeDictionary(which goes froms10DictionaryVtoSD), including standard substitution manglings for protocols (likeCollection). This results in a code-savings win (~470k for the standard library itself in development builds).Scope: Affects the mangled names in all Swift projects.
Risk: Low; mangling/demangling changes like this are straightforward and get heavily tested simply by building code.
Testing: Compiler regression tests
Reviewer: @jrose-apple , @jckarter
SR / Radar: rdar://problem/40468532