Revert "Restrict RemoteASTTypeBuilder::findModule() to the list of lo… #17384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aded modules." This reverts commit 30ea6ec. LLDB is smarter than I expected it to be. One of the failing tests "metatype" is very short and does not import any modules whatsoever. It turns out that swift_runtime->GetMetadataPromise() creates a RemoteAST with the Scratch AST context. LLDB does not pre-import any modules for the scratch AST context. Using the scratch context is actually the behavior we'd want for all kinds of dynamic type resolution, since we need to handle the worst-case dynamic type (a tuple of existentials that each originate from different modules that don't import each other) gracefully. So what I'm going to try next is revert the RemoteAST change and try to get the dynamic type resolution in this case to use the scratch AST context instead of the per-module AST context. I'm still going to add a flag to RemoteAST to indicate wether importing other modules should be allowed or not and set that according to whether this is a module context or the scratch context.
|
test with apple/swift-lldb#706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aded modules."
This reverts commit 30ea6ec.
LLDB is smarter than I expected it to be. One of the failing tests
"metatype" is very short and does not import any modules
whatsoever. It turns out that swift_runtime->GetMetadataPromise()
creates a RemoteAST with the Scratch AST context. LLDB does not
pre-import any modules for the scratch AST context.
Using the scratch context is actually the behavior we'd want for all
kinds of dynamic type resolution, since we need to handle the
worst-case dynamic type (a tuple of existentials that each originate
from different modules that don't import each other) gracefully.
So what I'm going to try next is revert the RemoteAST change and try
to get the dynamic type resolution in this case to use the scratch AST
context instead of the per-module AST context.
I'm still going to add a flag to RemoteAST to indicate wether
importing other modules should be allowed or not and set that
according to whether this is a module context or the scratch context.
rdar://problem/40950542