Add a convenience PatternBindingDecl::createImplicit member and mark some PBDs as implicit #17441
Conversation
|
I wasn't sure about two PBDs in TypeCheckRepl.cpp: and Currently neither variable nor pattern binding decl are marked implicit – should they be? |
|
TypeCheckREPL isn't super important, since it's only for the deprecated REPL. "Implicit" pretty much just means "this shouldn't be printed in a generated interface"*, and that's not going to matter much for these synthetic variables. But if it simplifies the code go ahead and clean it up. * "Implicit" does imply that the compiler synthesized the declaration as well, but there are non-implicit compiler-synthesized declarations too. |
|
@jrose-apple Ah okay, I see – thanks for clarifying! I think I'll leave them as-is in that case as I don't think it would be a simplification. |
hamishknight
force-pushed
the
implicit-pattern-binding-decls
branch
from
465d869 to
bc00026
Compare
…some PBDs as implicit Previously, some PBDs weren't being marked implicit even though the associated vars were implicit. PatternBindingDecl::createImplicit will be even nicer when we start parsing the location of the equals token.
hamishknight
force-pushed
the
implicit-pattern-binding-decls
branch
from
bc00026 to
f33844d
Compare
|
Just rebased to resolve a merge conflict. |
|
@swift-ci Please smoke test |
Previously, some PBDs weren't being marked implicit even though the associated vars were implicit.
PatternBindingDecl::createImplicitwill be even nicer when we start storing the location of the equals token.