[build-presets] Remove explicit =1 for impl params #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `utils/build-script-impl` shellscript takes arguments in the form of `--foo=bar` or `--baz`. In the second form, the argument is automatically interpreted as `--baz=1`. There is no need to manually specify `=1`, so remove it from the build presets. There is another reason to do this: the argument parser used by the Python `utils/build-script` is not as loose as the shellscript's. For a boolean switch such as `--baz`, the argument parser throws an exception if given a numerical value such as `--baz=1`. Therefore attempts to migrate certain parameters from the shellscript to the Python build script will encounter trouble when dealing with these explicit `--baz=1` parameters in the build presets. This commit does not touch any of the `--foo=0` parameters. Although they should be removed, it's trickier due to the inheritance of the build presets, and so I will do so in a later commit.
|
@swift-ci Please test |
|
Is this good to merge? There's no functional change here (sorry, should have mentioned that in the commit message). |
|
This LGTM. |
gottesmm
added a commit
that referenced
this pull request
Mar 22, 2016
…explicit-1 [build-presets] Remove explicit =1 for impl params
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The
utils/build-script-implshellscript takes arguments in the form of--foo=baror--baz. In the second form, the argument is automatically interpreted as--baz=1. There is no need to manually specify=1, so remove it from the build presets.There is another reason to do this: the argument parser used by the Python
utils/build-scriptis not as loose as the shellscript's. For a boolean switch such as--baz, the argument parser throws an exception if given a numerical value such as--baz=1. Therefore attempts to migrate certain parameters from the shellscript to the Python build script will encounter trouble when dealing with these explicit--baz=1parameters in the build presets.This commit does not touch any of the
--foo=0parameters. Although they should be removed, it's trickier due to the inheritance of the build presets, and so I will do so in a later commit.ResolvedRelated bug number: (SR-237)Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.