[Docs] Fix typo in GenericsManifesto.md. #17453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor clarification to "opening existentials" example.
|
@swift-ci Please smoke test |
CodaFi
reviewed
Jul 18, 2018
docs/GenericsManifesto.md
Outdated
| if let storedInE1 = e1 openas T { // T is a the type of storedInE1, a copy of the value stored in e1 | ||
| if let storedInE2 = e2 as? T { // is e2 also a T? | ||
| if let storedInE1 = e1 openas T { // T is the type of storedInE1, a copy of the value stored in e1 | ||
| if let storedInE2 = e2 as? T { // does e2 have type T? if so, copy its value to storedInE2 |
There was a problem hiding this comment.
I added capitalization in 2dc279f, is this what you had in mind?
I originally didn't capitalize comments for consistency with the rest of the doc.
Address comments by @CodaFi regarding capitalization.
|
@swift-ci please smoke test and merge |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@CodaFi This PR is ready to be merged. |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor clarification to "opening existentials" example.