-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Uninline mirror code #17476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
airspeedswift
merged 1 commit into
swiftlang:master
from
airspeedswift:uninline-mirrors
Jun 26, 2018
Merged
[stdlib] Uninline mirror code #17476
airspeedswift
merged 1 commit into
swiftlang:master
from
airspeedswift:uninline-mirrors
Jun 26, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please smoke benchmark |
@swift-ci please test |
@swift-ci please smoke test compiler performance |
Build comment file:Optimized (O)Regression (10)
Improvement (88)
No Changes (348)
Hardware Overview
|
@swift-ci please benchmark |
slavapestov
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Build comment file:Optimized (O)Regression (7)
Improvement (17)
No Changes (422)
Unoptimized (Onone)Regression (13)
Improvement (14)
No Changes (419)
Hardware Overview
|
bah, the cake was a lie. ah, well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes inlineability from mirror stuff in the stdlib. This code shouldn't be performance critical, and mirrors are likely to evolve in the future.
Also uninlines
debugDescription
for all types, which usually uses mirrors and is similarly not performance sensitive.