[master-next] Adjust syntax for setting an Optional member #17491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the ConditionalRequirements member of SpecializedProtocolConformance
to "{}" works fine with the swift-4.2-branch of swift-llvm, but with the
current upstream-with-swift branch, that results in a build failure:
error: use of overloaded operator '=' is ambiguous (with operand types
'Optional<ArrayRef<swift::Requirement> >' and 'void')
I suspect this is due to LLVM r322838 which made a bunch of changes to
LLVM's Optional type.
|
I'm going to merge this to un-break the master-next build, but Huon, please review and make sure this is still doing what you expect. |
|
Thanks for doing this. The original was very ambiguous, and unfortunately this isn't quite what was desired. #17499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the ConditionalRequirements member of SpecializedProtocolConformance
to "{}" works fine with the swift-4.2-branch of swift-llvm, but with the
current upstream-with-swift branch, that results in a build failure:
error: use of overloaded operator '=' is ambiguous (with operand types
'Optional<ArrayRefswift::Requirement >' and 'void')
I suspect this is due to LLVM r322838 which made a bunch of changes to
LLVM's Optional type.