[4.2] [TypeChecker] Fix crash with Objective C keypaths. #17504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a crash reported but do not have a test case and my attempt at creating one was unsuccessful. It seems like the issue is that we have an invalid decl that we attempt to access the interface type on, though, so hopefully this fixes the issue. I also tweaked the constraint generator to bail out when checkObjCKeyPathExpr fails. Potentially fixes: rdar://problem/40955755 (cherry picked from commit e0ce5fc)
And add a test that exercises this exit path (although it won't crash a compiler without my fixes because we do end up with ErrorType in that case, not a nullptr). (cherry picked from commit 846f159)
rudkx
changed the title
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a crash reported but do not have a test case and my attempt at
creating one was unsuccessful. It seems like the issue is that we have
an invalid decl that we attempt to access the interface type on,
though, so hopefully this fixes the issue.
I also tweaked the constraint generator to bail out when
checkObjCKeyPathExpr fails.
Potentially fixes: rdar://problem/40955755
(cherry picked from commit e0ce5fc)