Skip to content

[master-next] NFC: Rename variable from PR #17494 #17507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

bob-wilson
Copy link
Contributor

Jordan reviewed my change and suggested using a better variable name
to avoid potential confusion between "args" and "argv".

Jordan reviewed my change and suggested using a better variable name
to avoid potential confusion between "args" and "argv".
@bob-wilson bob-wilson requested a review from jrose-apple June 26, 2018 06:46
@bob-wilson
Copy link
Contributor Author

How about "ExpandedArgs"?

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's fine. I'm getting a sense that we can eliminate one more of the SmallVectors here, but that's not your responsibility.

@bob-wilson bob-wilson merged commit 8025e37 into swiftlang:master-next Jun 27, 2018
@bob-wilson bob-wilson deleted the pr16362-fix-followup branch June 27, 2018 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants