[Parse] <rdar://41154797> Detect eof in non-string-arg recovery loop in #error arg list. #17508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in #error arg list.
|
@swift-ci please test |
rintaro
approved these changes
Jun 26, 2018
| @@ -3285,7 +3285,7 @@ ParserResult<PoundDiagnosticDecl> Parser::parseDeclPoundDiagnostic() { | |||
| // Catch #warning(oops, forgot the quotes) | |||
| SourceLoc wordsStartLoc = Tok.getLoc(); | |||
|
|
|||
| while (!Tok.isAtStartOfLine() && Tok.isNot(tok::r_paren)) { | |||
| while (!Tok.isAtStartOfLine() && !Tok.isAny(tok::r_paren, tok::eof)) { | |||
There was a problem hiding this comment.
Tok.isNot(tok::r_paren, tok::eof) should also work, but I personally prefer !Tok.isAny( 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser could hang while trying to recover from an unexpected token in the arg list of a pound-diagnostic, and met with and unterminated token. Fix this by noticing eof in the loop.
rdar://41154797