Skip to content

[test] Move test using StdlibCollectionsUnittest to validation-test. #17511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2018
Merged

[test] Move test using StdlibCollectionsUnittest to validation-test. #17511

merged 1 commit into from
Jun 26, 2018

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Jun 26, 2018

No description provided.

@huonw
Copy link
Contributor Author

huonw commented Jun 26, 2018

@swift-ci please smoke test

(Just FYI @ahoppen: it's easy to forget and, worse, local state can disguise making a mistake, but StdlibCollectionUnittest is only properly built for validation-tests.)

@huonw
Copy link
Contributor Author

huonw commented Jun 26, 2018

@swift-ci please smoke test

@huonw huonw merged commit d987ca8 into swiftlang:master Jun 26, 2018
@ahoppen
Copy link
Member

ahoppen commented Jun 26, 2018

@huonw Thanks a lot for fixing this 🙏🏽. I didn't know StdlibCollectionUnittest was only built there.

@huonw huonw deleted the move-test branch June 26, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huonw @ahoppen