Skip to content

[CMake] Export target libraries. #17525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2018
Merged

[CMake] Export target libraries. #17525

merged 1 commit into from
Jun 28, 2018

Conversation

dcci
Copy link
Member

@dcci dcci commented Jun 26, 2018

lldb needs this to link against reflection.
Patch by Michael Gottesman, I take no credit.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@dcci dcci requested a review from gottesmm June 26, 2018 20:38
@dcci
Copy link
Member Author

dcci commented Jun 26, 2018

@swift-ci please test

@dcci dcci mentioned this pull request Jun 26, 2018
Closed
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 446c7a438d2cd07e7f0996bcf2461746627b24d8

@dcci
Copy link
Member Author

dcci commented Jun 26, 2018

ugh, this broke linux.

15:58:44 -- Configuring done
15:58:45 CMake Error:
15:58:45   given target "swiftCore-linux-x86_64" more than once.
15:58:45

I need to understand why.

@dcci
Copy link
Member Author

dcci commented Jun 27, 2018

@swift-ci please test

1 similar comment
@dcci
Copy link
Member Author

dcci commented Jun 27, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 446c7a438d2cd07e7f0996bcf2461746627b24d8

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 05877f7014118728fe69d9d18ee56322fe8582e2

@dcci
Copy link
Member Author

dcci commented Jun 27, 2018

@swift-ci please test

1 similar comment
@dcci
Copy link
Member Author

dcci commented Jun 27, 2018

@swift-ci please test

[CMake] Export target libraries.
87f61d4 
lldb needs this to link against reflection.
Patch by Michael Gottesman, I take no credit.
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - bac57fd6ad259b615e2295d271758cceece71219

@dcci
Copy link
Member Author

dcci commented Jun 27, 2018

@swift-ci please test

1 similar comment
@dcci
Copy link
Member Author

dcci commented Jun 27, 2018

@swift-ci please test

@gottesmm
Copy link
Contributor

@dcci Looks like my magic hands did the trick.

@dcci
Copy link
Member Author

dcci commented Jun 28, 2018

@gottesmm indeed, thanks!

@dcci dcci merged commit 02122f6 into swiftlang:master Jun 28, 2018
@gottesmm
Copy link
Contributor

@dcci see it wasn't too scary = p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcci @swift-ci @gottesmm