[DefiniteInitialization] Check whether globals captured by top-level defer statements are initialized. #17542
Conversation
ravikandhadai
requested review from
jckarter,
devincoughlin,
rjmccall and
gottesmm
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
Pushed a new commit that resolves merge conflicts |
| @@ -1243,10 +1244,13 @@ void LifetimeChecker::handleEscapeUse(const DIMemoryUse &Use) { | |||
|
|
|||
| Diag<StringRef, bool> DiagMessage; | |||
| if (isa<MarkFunctionEscapeInst>(Inst)) { | |||
There was a problem hiding this comment.
Can you add comments here explaining why this code is arranged this way and how that maps to code? The reason I am asking is that you have this paged into your head right now. We should document this behavior.
There was a problem hiding this comment.
I am fine if you want to do that in a subsequent commit.
There was a problem hiding this comment.
Okay. I have added some explanation to this piece of code. My exact change here is to just introduce a new else if condition to the logic in the "MarkFunctionEscapeInst" branch, which is something I understand well. The rest of the logic existed before. However, I have documented my overall understanding of the code here.
defer statements are initialized. <rdar://30720636>
|
@swift-ci please smoke test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
rdar://30720636