Skip to content

SILGen: Pseudogeneric partial applications do not produce pseudogeneric results. #17547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2018
Merged

SILGen: Pseudogeneric partial applications do not produce pseudogeneric results. #17547

merged 1 commit into from
Jun 27, 2018

Conversation

jckarter
Copy link
Contributor

partial_apply always fully applies the generic environment, so the result is not generic at all. Fixes rdar://problem/41474371 | SR-8107.

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

@swift-ci Please test source compatibility

@jckarter jckarter requested a review from slavapestov June 27, 2018 03:36
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 11bcd69061f61fe89473769ed79b3d01d62f3754

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 11bcd69061f61fe89473769ed79b3d01d62f3754

slavapestov
slavapestov approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I wonder if we can assert anywhere that a non-generic function cannot have the pseudogeneric bit set, but that's not important for this fix.

@jckarter
SILGen: Pseudogeneric partial applications do not produce pseudogener…
55706bf 
…ic results.

partial_apply always fully applies the generic environment, so the result is not generic at all. Fixes rdar://problem/41474371 | SR-8107.
@jckarter jckarter force-pushed the pseudogeneric-partial-apply branch from 11bcd69 to 55706bf Compare June 27, 2018 16:26
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 11bcd69061f61fe89473769ed79b3d01d62f3754

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 11bcd69061f61fe89473769ed79b3d01d62f3754

@jckarter
Copy link
Contributor Author

We could assert that in SILFunctionType::get. I'll try that.

@jckarter jckarter merged commit 7a7bb40 into swiftlang:master Jun 27, 2018
@jckarter jckarter mentioned this pull request Jun 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jckarter @swift-ci @slavapestov