Skip to content

SIL: Assert that SILFunctionTypes are only @pseudogeneric when they have generic arguments. #17561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2018
Merged

SIL: Assert that SILFunctionTypes are only @pseudogeneric when they have generic arguments. #17561

merged 1 commit into from
Jul 7, 2018

Conversation

jckarter
Copy link
Contributor

No description provided.

@jckarter jckarter requested a review from slavapestov June 27, 2018 17:40
@jckarter
Copy link
Contributor Author

@swift-ci Please test

jrose-apple
jrose-apple reviewed Jun 27, 2018
View reviewed changes
test/SILGen/objc_block_to_func_to_block.swift Outdated
@@ -0,0 +1,8 @@
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -import-objc-header %S/Inputs/objc_block_to_func_to_block.h -emit-silgen -verify %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to use the real overlays with the mock SDK, which isn't really safe.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7c9c4b1b67ee36039ca689d6c1b2ae6ea661ff32

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7c9c4b1b67ee36039ca689d6c1b2ae6ea661ff32

@jckarter jckarter force-pushed the silfunctiontype-pseudogeneric-iff-generic branch from 7c9c4b1 to 0bbc219 Compare June 27, 2018 18:15
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7c9c4b1b67ee36039ca689d6c1b2ae6ea661ff32

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7c9c4b1b67ee36039ca689d6c1b2ae6ea661ff32

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0bbc219d9924f071d388f3b7bbb8610cf3b2be18

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0bbc219d9924f071d388f3b7bbb8610cf3b2be18

@jckarter
SIL: Assert that SILFunctionTypes are only @pseudogeneric when they h…
9833fb4 
…ave generic arguments.

And fix up the places where we would set or propagate the 'pseudogeneric' bit even for nongeneric types.
@jckarter jckarter force-pushed the silfunctiontype-pseudogeneric-iff-generic branch from 0bbc219 to 9833fb4 Compare July 6, 2018 22:37
@jckarter
Copy link
Contributor Author

jckarter commented Jul 6, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - 0bbc219d9924f071d388f3b7bbb8610cf3b2be18

@jckarter jckarter merged commit 238aa2d into swiftlang:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple left review comments

@slavapestov slavapestov Awaiting requested review from slavapestov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jckarter @swift-ci @jrose-apple