Revert "[DefiniteInitialization] Fix the bug that allows overwriting immutable" #17563
Conversation
|
@swift-ci please test |
|
Can we update the benchmarks instead? Does this cause breakage outside the benchmarks? Rather than eliminate the fix entirely, if we need to preserve compatibility, we generally make the new diagnostic a warning in the current language version (4 currently) and upgrade to an error in the next language version (5). |
|
@ravikandhadai Your commit message here needs more information. What benchmarks failed? What was the error message? Without that it is impossible to know anything from what you wrote here and really it isn't useful. |
|
@jckarter I am sorry for not being clear. I just would like to revert it for the time being while I am investigating the issue. It looks like there could be a bug in the DI, the benchmarks appears to the correct. |
|
@gottesmm Please see this radar for more information: rdar://41501480 |
…immutable" This reverts commit 82abf97 as it breaks compatability of some existing benchmarks. <rdar://41501480>
ravikandhadai
force-pushed
the
DIOptWritePR
branch
from
233c4ef to
964397c
Compare
|
@swift-ci please test |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
This reverts commit 82abf97 as it breaks
compatability of some existing benchmarks.