Skip to content

[Gardening] Migrate More Tests To Swift 4 #17568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 27, 2018
Merged

[Gardening] Migrate More Tests To Swift 4 #17568

merged 7 commits into from
Jun 27, 2018

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jun 27, 2018

Continues the work in #17535

Before

$ git grep --name-only "swift-version 3" | grep -Ev 'Compatibility/' | wc -l
> 238

After

$ git grep --name-only "swift-version 3" | grep -Ev 'Compatibility/' | wc -l
> 158

@CodaFi CodaFi requested a review from slavapestov June 27, 2018 20:35
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 27, 2018

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 27, 2018

⛵️

@CodaFi CodaFi merged commit 1f91a29 into swiftlang:master Jun 27, 2018
@CodaFi CodaFi deleted the fourward-march branch June 27, 2018 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @slavapestov