[4.2][CodeComplete] Fix several crashes in getOperatorCompletions #17573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
rdar://problem/41232519 rdar://problem/41159258
In getOperatorCompletions(), for each every known operators, temporary expressions are created and typechecked. In this process, typechecker may set the type of the parsed expression. That may cause non-accurate completion results or crash at worst. rdar://problem/28188259
rintaro
force-pushed
the
4.2-ide-complete-sequence
branch
from
e31b7dd to
3402127
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-Pick of #17556 reviewed by @benlangmuir
AssignExprwas wrongly reused in re-typechecking. We need to unfold/flatten them before re-typechekcing.getOperatorCompletions(), for each every known operators, temporary expressions are created and typechecked. In this process, typechecker may set the type of the parsed expression. That may cause inaccurate completion results or crash at worst.rdar://problem/28188259
rdar://problem/41232519
rdar://problem/41159258