Skip to content

[CodeComplete] Typecheck SubscriptDecl context prior to completion #17588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2018
Merged

[CodeComplete] Typecheck SubscriptDecl context prior to completion #17588

merged 1 commit into from
Jun 28, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 28, 2018

Completing types in signature depends on its GenericEnvironment which is set during typechecking.
Previously, completing signature using generic type used to cause assertion failure. e.g.

extension Collection {
  subscript(some index: Int) -> Iterator.<COMPLETE HERE>

rdar://problem/41227754

@rintaro
[CodeComplete] Typecheck SubscriptDecl context prior to completion
bccfd85 
Completing signature depends on its GenericEnvironment which is set
during typechecking. Previously, completing signature using generic type
used to cause assertion failure. e.g.

  extension Collection {
    subscript(some index: Int) -> Iterator.<COMPLETE HERE>

rdar://problem/41227754
@rintaro rintaro requested a review from DougGregor June 28, 2018 08:40
@rintaro
Copy link
Member Author

rintaro commented Jun 28, 2018

@swift-ci Please smoke test

DougGregor
DougGregor approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rintaro rintaro merged commit b17bfc1 into swiftlang:master Jun 28, 2018
@rintaro rintaro deleted the ide-complete-rdar41227754 branch June 28, 2018 16:56
@rintaro rintaro mentioned this pull request Jun 28, 2018
Merged
@shahmishal
Copy link
Member

@rintaro Can these test failures related to this PR?

https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/4658/

Test Result (20 failures / +20)
Swift(linux-x86_64).SourceKit/Sema.sema_protocol_stubs.swift
Swift(linux-x86_64).SourceKit/Sema.sema_diag_after_edit-2.swift
Swift(linux-x86_64).SourceKit/Sema.sema_diag_after_edit_fixit.swift
Swift(linux-x86_64).SourceKit/Sema.sema_module.swift
Swift(linux-x86_64).SourceKit/Sema.sema_edits.swift
Swift(linux-x86_64).SourceKit/Sema.sema_config.swift
Swift(linux-x86_64).SourceKit/Sema.sema_symlink.swift
Swift(linux-x86_64).SourceKit/Sema.sema_big_array.swift
Swift(linux-x86_64).SourceKit/Sema.sema_unavailable.swift
Swift(linux-x86_64).SourceKit/Sema.main.swift
Swift(linux-x86_64).SourceKit/Sema.sema_lazy_var.swift
Swift(linux-x86_64).SourceKit/Sema.objc_attr_without_import.swift
Swift(linux-x86_64).SourceKit/Sema.sema_playground.swift
Swift(linux-x86_64).SourceKit/Sema.sema_forbid_typecheck.swift
Swift(linux-x86_64).SourceKit/Sema.placeholders.swift
Swift(linux-x86_64).SourceKit/Sema.sema_diag_after_edit.swift
Swift(linux-x86_64).SourceKit/Sema.sil_diags.swift
Swift(linux-x86_64).SourceKit/Sema/enum-toraw.enum-toraw.swift
Swift(linux-x86_64).SourceKit/SyntaxMapData.diags.swift
Swift(linux-x86_64).SourceKit/Misc.ignore_index_store_flag.swift

@rintaro
Copy link
Member Author

rintaro commented Jun 29, 2018

I don't think so. Please let me know if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @shahmishal @DougGregor