Don't try to build compiler-rt when cross-compiling #1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm-beanz Could you take a look? |
|
The option you want to be turning Off is LLVM_TOOL_COMPILER_RT_BUILD. LLVM_BUILD_EXTERNAL_COMPILER_RT is just what controls whether or not you use an in-tree built clang. |
|
Updated. I think the bugfix to |
|
LGTM. |
vedantk
added a commit
that referenced
this pull request
Mar 21, 2016
Don't try to build compiler-rt when cross-compiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This PR makes build-script skip building compiler-rt when cross-compiling.
A user has reported a build-time failure when building swift-compiler-rt along with
--cross-compile-tools-deployment-targetsset. We should have a workaround in place before investigating a longer-term fix.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.