[4.2] IRGen: Fix multi-payload enum lowering #17590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have a private resilient enum that is resilient because one of its payloads is resilient but we have disabled resilience in the context of lowering the enum as a class member (sigh), we must consider it's payload's layout enum in the minimal domain (ignore the private visibility) because we don't truly know the layout. * Scope: Private enums that contain a resilient payload and are used as a stored property inside of a class will cause crashes * Risk: Low * Reviewed by: Slava * Testing: CI test cases added rdar://41308521
|
@swift-ci Please test |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a private resilient enum that is resilient because one of
its payloads is resilient but we have disabled resilience in the
context of lowering the enum as a class member (sigh), we must consider
it's payload's layout enum in the minimal domain (ignore the private
visibility) because we don't truly know the layout.
Scope: Private enums that contain a resilient payload and are used as
a stored property inside of a class will cause crashes. This regression was introduced recently when we made resilient properties no resilient when used as stored properties in classes to fix ObjectiveC's incapability to handle resilient stored properties.
Risk: Low
Reviewed by: Slava
Testing: CI test cases added
rdar://41308521