[Type checker] Look through optionals when checking for rethrows. #17622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
force-pushed
the
fix-optional-rethrows-checking
branch
from
f7a0958 to
534681a
Compare
|
@swift-ci please smoke test and merge |
huonw
previously approved these changes
Jun 29, 2018
…hrows. Fixes SR-5427.
DougGregor
force-pushed
the
fix-optional-rethrows-checking
branch
from
534681a to
932e9be
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
My earlier fix was incorrect. Asking for a re-review |
DougGregor
dismissed
huonw’s stale review
My fix was incorrect; the new approach is different and needs re-review.
rjmccall
approved these changes
Jun 29, 2018
| @@ -134,6 +134,9 @@ class AbstractFunction { | |||
| fn = conversion->getSubExpr()->getValueProvidingExpr(); | |||
| } else if (auto conversion = dyn_cast<BindOptionalExpr>(fn)) { | |||
| fn = conversion->getSubExpr()->getValueProvidingExpr(); | |||
| // Look through optional injections | |||
There was a problem hiding this comment.
For consistency, this should end in a period.
There was a problem hiding this comment.
Indeed. I'll tack that on in some other random PR I land today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SR-5427.