stdlib: Remove Collection.randomElement customization point. #17637
Conversation
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
I don't believe this would pass the tests. You're going to need to move the implementation from |
|
OK, thanks! |
jckarter
force-pushed
the
remove-randomelement-customization-point
branch
from
75727ac to
21db37d
Compare
|
@swift-ci Please test |
|
Build failed |
As proposed and accepted in amendment swiftlang/swift-evolution#863. rdar://problem/41067949
jckarter
force-pushed
the
remove-randomelement-customization-point
branch
from
21db37d to
04b5174
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
| return Self(truncatingIfNeeded: generator.next() as Magnitude) | ||
| } | ||
| // Need to widen delta to account for the right-endpoint of a closed range. | ||
| delta += 1 |
There was a problem hiding this comment.
@stephentyrone It looks like the optimizer does figure out that it is not necessary to check for the overflow, because you did it manually in the if block above… but still, wouldn't it make sense to go with delta &+= 1 here?
As proposed and accepted in amendment swiftlang/swift-evolution#863. rdar://problem/41067949