[4.2] Sema: Diagnose completely unapplied references to mutating methods. #17653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currying behavior of method references completely breaks in the face of `inout` semantics, even moreso with exclusivity enforcement, but we failed to diagnose these references in Swift 4 and previous versions. Raise a compatibility warning when these references are found in Swift 4 code, or error in Swift 5 and later. Simplify the partial application logic here slightly too now that standalone functions do not allow currying. Addresses rdar://problem/41361334 | SR-8074.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The currying behavior of method references completely breaks in the face of
inoutsemantics, even moreso with exclusivity enforcement, but we failed to diagnose these references in Swift 4 and previous versions. Raises a compatibility warning when these references are found in Swift 4 code, or error in Swift 5 and later.Scope: Warns about an unsupportable invalid code formation that was accidentally accepted.
Issue: rdar://problem/41361334 | SR-8074.
Risk: Low, introduces a warning for code that would be miscompiled
Testing: Swift CI, compatibility suite
Reviewed by: @slavapestov