Skip to content

IndexSet.union performance improvement #17666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RobertPieta
Copy link

Improves performance of IndexSet.union by replacing a loop with a struct copy of the more sparse set. Same change as #1603 merged into swift-corelibs-foundation.

@jrose-apple jrose-apple requested review from millenomi and phausler July 2, 2018 19:29
@jrose-apple
Copy link
Contributor

@swift-ci Please test

Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems quite reasonable to me

@CodaFi
Copy link
Contributor

CodaFi commented Nov 18, 2019

Shepherding an updated copy of this patch in #28325. Closing this copy out.

Thanks!

@CodaFi CodaFi closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants