[AST] Centralize storage of the overridden declarations of a declaration #17682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last use of this went away a loooooong time ago. NFC.
…o field. To help us isolate the state that is primarily managed through the request-evaluator, encapsulate that information in a LazySemanticInfo member (as we do with superclass info and enum raw type info) rather than scattering it around the AST.
This function was checking isObjC() first, which is potentially expensive to compute, and *then* performing structural checks. Re-order the checking so that we perform the (cheap, lower-dependency) structural checks first, and then semantic isObjC() check later.
…aration. Several kinds of declarations can override other declarations, but the computation and storage for these “overridden” declarations was scattered in at least 3 different places, with different resolution paths. Pull them all together into two bits of LazySemanticInfo in ValueDecl (“have we computed overrides?” and “are there any overrides?”), with a side table for the actual list of overrides. One side effect here is that the AST can now represent multiple overridden declarations, although only associated type declarations track this information. Start using LazyResolver::resolveOverriddenDecl() more consistently, unifying it with the separate path we had for associated type overrides. All of this is staging for a move to the request-evaluator for overridden declaration computation.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several kinds of declarations can override other declarations, but the
computation and storage for these “overridden” declarations was scattered in
at least 3 different places, with different resolution paths. Pull them
all together into two bits of
LazySemanticInfoinValueDecl(“have we computedoverrides?” and “are there any overrides?”), with a side table for the
actual list of overrides.
One side effect here is that the AST can now represent multiple overridden
declarations, although only associated type declarations track this
information.
Start using
LazyResolver::resolveOverriddenDecl()more consistently, unifyingit with the separate path we had for associated type overrides. All of this
is staging for a move to the request-evaluator for overridden declaration
computation.