Skip to content

Space Engine: check for empty spaces in Space::forConstructor #17684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2018
Merged

Space Engine: check for empty spaces in Space::forConstructor #17684

merged 1 commit into from
Jul 3, 2018

Conversation

jrose-apple
Copy link
Contributor

This is the last optimization performed in Space::simplify, so now we can remove that as well. No intended functionality change.

@jrose-apple
Space Engine: check for empty spaces in Space::forConstructor
7405394 
This is the last optimization performed in Space::simplify, so now we
can remove that as well. No intended functionality change.
@jrose-apple jrose-apple requested review from xedin and CodaFi July 2, 2018 22:51
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test compiler performance

xedin
xedin approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I really wanted to remove simplify, but got side-tracked by other stuff, so now I'm happy :)

@swift-ci
Copy link
Contributor

swift-ci commented Jul 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 7405394

@jrose-apple
Copy link
Contributor Author

SourceKit test failed

[ RUN      ] EditTest.DiagsAfterCloseAndReopen
/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/unittests/SourceKit/SwiftLang/EditingTest.cpp:262: Failure
Value of: expired
  Actual: true
Expected: false
no second notification
[  FAILED  ] EditTest.DiagsAfterCloseAndReopen (11148 ms)

@benlangmuir, any ideas?

@swift-ci Please test macOS

@swift-ci
Copy link
Contributor

swift-ci commented Jul 3, 2018

Build comment file:

Summary for master full

Unexpected test results, excluded stats for Core, xcproj, StencilSwiftKit, CoreStore, Turnstile, ObjectMapper

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 1,137,324,716 1,137,325,092 376 0.0%
time.swift-driver.wall 2210.7s 2210.4s -282.9ms -0.01%

debug-batch detailed

Regressed (3)
name old new delta delta_pct
AST.NumASTBytesAllocated 27,517,068,693 27,808,936,697 291,868,004 1.06% ⛔
Driver.NumDriverPipePolls 260,077 268,867 8,790 3.38% ⛔
Driver.NumDriverPipeReads 286,742 293,299 6,557 2.29% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (74)
name old new delta delta_pct
AST.NumDecls 82,964 82,964 0 0.0%
AST.NumDependencies 158,496 158,496 0 0.0%
AST.NumImportedExternalDefinitions 1,394,849 1,394,849 0 0.0%
AST.NumInfixOperators 26,388 26,388 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 207,331 207,331 0 0.0%
AST.NumLocalTypeDecls 8 8 0 0.0%
AST.NumObjCMethods 22,546 22,546 0 0.0%
AST.NumPostfixOperators 14 14 0 0.0%
AST.NumPrecedenceGroups 16,201 16,201 0 0.0%
AST.NumPrefixOperators 127 127 0 0.0%
AST.NumReferencedDynamicNames 180 180 0 0.0%
AST.NumReferencedMemberNames 3,795,617 3,795,617 0 0.0%
AST.NumReferencedTopLevelNames 272,867 272,867 0 0.0%
AST.NumSourceBuffers 362,793 362,793 0 0.0%
AST.NumSourceLines 2,351,367 2,351,367 0 0.0%
AST.NumSourceLinesPerSecond 1,763,218 1,775,348 12,130 0.69%
AST.NumTotalClangImportedEntities 4,586,913 4,586,913 0 0.0%
AST.NumUsedConformances 196,467 196,467 0 0.0%
Driver.ChildrenMaxRSS 70,419,691,520 70,402,996,224 -16,695,296 -0.02%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 16,691 16,691 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 13,236 13,236 0 0.0%
IRModule.NumIRBasicBlocks 3,757,962 3,757,962 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 2,146,382 2,146,382 0 0.0%
IRModule.NumIRGlobals 2,274,223 2,274,223 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 42,169,073 42,169,073 0 0.0%
IRModule.NumIRNamedMetaData 81,820 81,820 0 0.0%
IRModule.NumIRValueSymbols 3,914,175 3,914,175 0 0.0%
LLVM.NumLLVMBytesOutput 1,137,324,716 1,137,325,092 376 0.0%
Parse.NumFunctionsParsed 149,311 149,311 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,529,462 1,529,462 0 0.0%
SILModule.NumSILGenGlobalVariables 24,821 24,821 0 0.0%
SILModule.NumSILGenVtables 16,289 16,289 0 0.0%
SILModule.NumSILGenWitnessTables 42,913 42,913 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 1,385,772 1,385,772 0 0.0%
SILModule.NumSILOptGlobalVariables 25,588 25,588 0 0.0%
SILModule.NumSILOptVtables 25,013 25,013 0 0.0%
SILModule.NumSILOptWitnessTables 74,612 74,612 0 0.0%
Sema.EnumRawTypeRequest 14,950 14,950 0 0.0%
Sema.InheritedTypeRequest 96,048 96,048 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 23,491 23,491 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 3,940,958 3,940,227 -731 -0.02%
Sema.NominalTypeLookupDirectCount 28,657,478 28,370,279 -287,199 -1.0%
Sema.NumConformancesDeserialized 4,815,717 4,815,717 0 0.0%
Sema.NumConstraintScopes 10,288,732 10,288,732 0 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 30,213,326 30,213,326 0 0.0%
Sema.NumDeclsDeserialized 33,901,339 33,901,339 0 0.0%
Sema.NumDeclsValidated 2,891,649 2,891,649 0 0.0%
Sema.NumFunctionsTypechecked 925,101 925,101 0 0.0%
Sema.NumGenericSignatureBuilders 1,617,729 1,617,729 0 0.0%
Sema.NumLazyGenericEnvironments 6,542,063 6,542,063 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 745,060 745,060 0 0.0%
Sema.NumLazyIterableDeclContexts 5,633,443 5,633,443 0 0.0%
Sema.NumTypesDeserialized 35,639,107 35,639,107 0 0.0%
Sema.NumTypesValidated 3,039,780 3,039,780 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 3,802,062 3,802,062 0 0.0%
Sema.SuperclassTypeRequest 55,989 55,989 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 988,672,620 988,672,688 68 0.0%
time.swift-driver.wall 3610.5s 3610.0s -448.6ms -0.01%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 309,933 309,933 0 0.0%
AST.NumLoadedModules 19,326 19,326 0 0.0%
AST.NumTotalClangImportedEntities 1,012,211 1,012,211 0 0.0%
AST.NumUsedConformances 201,980 201,980 0 0.0%
IRModule.NumIRBasicBlocks 3,133,390 3,133,390 0 0.0%
IRModule.NumIRFunctions 1,737,620 1,737,620 0 0.0%
IRModule.NumIRGlobals 1,890,833 1,890,833 0 0.0%
IRModule.NumIRInsts 29,850,598 29,850,598 0 0.0%
IRModule.NumIRValueSymbols 3,326,865 3,326,865 0 0.0%
LLVM.NumLLVMBytesOutput 988,672,620 988,672,688 68 0.0%
SILModule.NumSILGenFunctions 739,648 739,648 0 0.0%
SILModule.NumSILOptFunctions 999,915 999,915 0 0.0%
Sema.NumConformancesDeserialized 2,315,353 2,315,353 0 0.0%
Sema.NumConstraintScopes 10,170,429 10,170,429 0 0.0%
Sema.NumDeclsDeserialized 7,217,770 7,217,770 0 0.0%
Sema.NumDeclsValidated 2,086,922 2,086,922 0 0.0%
Sema.NumFunctionsTypechecked 418,120 418,120 0 0.0%
Sema.NumGenericSignatureBuilders 356,034 356,034 0 0.0%
Sema.NumLazyGenericEnvironments 1,249,483 1,249,483 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 152,831 152,831 0 0.0%
Sema.NumLazyIterableDeclContexts 850,001 850,001 0 0.0%
Sema.NumTypesDeserialized 8,734,567 8,734,567 0 0.0%
Sema.NumTypesValidated 1,366,194 1,366,194 0 0.0%

@jrose-apple jrose-apple merged commit 454afbd into swiftlang:master Jul 3, 2018
@jrose-apple jrose-apple deleted the meta-simplification branch July 3, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@CodaFi CodaFi CodaFi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrose-apple @swift-ci @xedin @CodaFi