[Sema] Don't make argument paren target of RebindSelfInConstructorExpr #17696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
For `use(self.init())`, target of RebindSelfInConstructorExpr should be call expression instead of paren expression. rdar://problem/41416911 Possibly: rdar://problem/41593987
rintaro
force-pushed
the
sema-rebindself-target
branch
from
717bd86 to
e694837
Compare
|
@swift-ci Please smoke test |
|
@slavapestov Could you take a look? |
beccadax
approved these changes
Jul 19, 2018
There was a problem hiding this comment.
I wrote a nearly identical change recently, but I think your handling of the CallArgs check is more accurate than mine.
|
@brentdax Sorry for delay, I was on vacation. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For (previously crashing):
target of
RebindSelfInConstructorExprshould be call expressionself.init()instead of paren(self.init()).rdar://problem/41416911
Possibly: rdar://problem/41593987