[Runtime] Remove dependency on Compiler.h from Config.h. #17702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime doesn't really need Compiler.h. It just needs some visibility macros which can be inlined here instead of pulling the whole heavyweight header (including its transitive closure, llvm-config.h). This is becoming more important now that Compiler.h includes C++ headers (namely, <new>), and swift/Runtime/Config.h can be included from C or Objective-C files (causing build failures). <rdar://problem/35860874>
jrose-apple
reviewed
Jul 3, 2018
| /// Extend the default __GNUC_PREREQ even if glibc's features.h isn't | ||
| /// available. | ||
| #ifndef SWIFT_RUNTIME_GNUC_PREREQ | ||
| # if defined(__GNUC__) && defined(__GNUC_MINOR__) && defined(__GNUC_PATCHLEVEL__) |
There was a problem hiding this comment.
Are we up to the point where the runtime is always built with the just-built Clang? If so, we can drop all this too.
There was a problem hiding this comment.
Yes, we always use the just-built Clang to build the runtime. We've discussed changes to allow building the stdlib and runtime separately (where there may not be a just-built Clang), but in that case, if someone chooses to use that option (in some future version where it is supported), I think we will then require the system compiler to be a suitably recent version of Clang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime doesn't really need Compiler.h. It just needs some
visibility macros which can be inlined here instead of pulling
the whole heavyweight header (including its transitive closure,
llvm-config.h). This is becoming more important now that Compiler.h
includes C++ headers (namely, ), and swift/Runtime/Config.h
can be included from C or Objective-C files (causing build failures).
rdar://problem/35860874