[4.2] [Clang importer] Allow us to wire up overrides with generic classes. #17706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A use of "getAs<ClassType>()" when trying to wire up the overrides of an imported Objective-C initializer meant that imported Objective-C generic classes didn't get their overrides set properly. This could lead to redundant initializers; use a proper accessor, since we only need the ClassDecl anyway. Fixes SR-8142 / rdar://problem/41591677.
|
@swift-ci please test |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Imported generic Objective-C classes could end up importing initializers
that were not considered "overrides" of their superclass initializers, which could lead to ambiguities
due to initializers with the same signature being visible in multiple superclasses (e.g.,
UIViewController.init()andMyGenericObjCClass.init()would both exist but be ambiguous). Ensure that overrides are set up properly to address this Swift 4.2 regression.Scope: Affects the initializers of imported generic Objective-C classes.
Risk: Low; this will add the "overrides" relationship among imported initializers for generic classes, but does not affect other relationships.
Testing: Compiler regression tests, include new tests.
Reviewer: @jrose-apple
SR / Radar: SR-8142 / rdar://problem/41591677