[ClangImporter] Remove support for Swift 3 mode #17722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not as exciting as some of the other components, but still!
|
@swift-ci Please test |
|
Build failed |
|
@dcci, what's the deal with these LLDB tests? At least one of these that's failing has nothing to do with my change (TestSwiftConditionalBreakpoint). |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test Linux |
|
Cool! Can you land the test changes first, even if we wait to land the rest? |
|
*shrug* You already got all the important test changes; the remaining ones are just removing explicit |
|
This has been sitting around, so just in case… @swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not as exciting as some of the other components, but still!