Skip to content

Remove redundant generic signature pointer #17745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

airspeedswift
Copy link
Member

syntheticSig is never assigned a value other than nullptr, and only tested in an assert, so could be removed instead of the warning suppressed.

@airspeedswift
Copy link
Member Author

airspeedswift commented Jul 4, 2018

@DougGregor @jckarter it could be the changes that resulted in this warning might not have been correct though – is the intention to assign to is here instead?

@airspeedswift
Copy link
Member Author

@swift-ci please test

@slavapestov
Copy link
Contributor

Since nothing uses it, it’s fine to remove.

@airspeedswift airspeedswift merged commit 3add046 into swiftlang:master Jul 5, 2018
@airspeedswift airspeedswift deleted the redundant-generic-sig branch July 5, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants