Remove -swift-version 3 from a handful of tests and update them appro… #17748
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // RUN: %target-typecheck-verify-swift | ||
|
|
||
| func test1(_: ()) {} // expected-note {{'test1' declared here}} | ||
| test1() // expected-error {{missing argument for parameter #1 in call}} | ||
|
|
||
| enum Result<T> { | ||
| case success(T) // expected-note {{'success' declared here}} | ||
| } | ||
| func test3(_: Result<()>) {} | ||
| test3(.success()) // expected-error {{missing argument for parameter #1 in call}} | ||
|
|
||
| func toString(indexes: Int?...) -> String { | ||
| let _ = indexes.reduce(0) { print($0); return $0.0 + ($0.1 ?? 0)} | ||
| // expected-error@-1 {{contextual closure type '(_, Int?) throws -> _' expects 2 arguments, but 1 was used in closure body}} | ||
| let _ = indexes.reduce(0) { (true ? $0 : (1, 2)).0 + ($0.1 ?? 0) } | ||
| // expected-error@-1 {{contextual closure type '(_, Int?) throws -> _' expects 2 arguments, but 1 was used in closure body}} | ||
| _ = ["Hello", "Foo"].sorted { print($0); return $0.0.count > ($0).1.count } | ||
| // expected-error@-1 {{argument passed to call that takes no arguments}} | ||
| } | ||
|
|
||
| func doit(_ x: Int) -> Bool { return x > 0 } | ||
| let _: ((String, Int)) -> [String:Bool] = { [$0: doit($1)] } | ||
| // expected-error@-1 {{closure tuple parameter '(String, Int)' does not support destructuring with implicit parameters}} | ||
| func returnClosure() -> ((Int, Int)) -> Bool { return {$1 > $0} } | ||
| // expected-error@-1 {{closure tuple parameter '(Int, Int)' does not support destructuring with implicit parameters}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did these completions go away? Is it a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked that same question of @benlangmuir on the other PR. I haven't had a chance to look into it at all, but if it's unexpected we can open a JIRA and look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed a radar about it already but I thought you determined the change was correct. Until we find out can you leave this test as is for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slavapestov I'm not planning on merging anything until @benlangmuir has a chance to reply to my question below.