-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[build_support] Added -sparse option for llvm-profdata if supported #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lgtm! |
@gribozavr Mind taking a look? Thanks! |
7e983ca
to
6404b93
Compare
@harlanhaskins Does the 'please test' path invoke the profile merger? |
Nope -- in fact, swift-ci doesn't have a command for that. So this won't be tested by CI... |
I'm gonna write some tests for it. |
Could I get a @swift-ci please python lint? |
@swift-ci Please python lint |
Looks like that's just not gonna do anything right now. ¯_(ツ)_/¯ |
@swift-ci Please python lint |
@shahmishal Shouldn't you be at home and not working? 😂 |
@swift-ci Please python lint |
@harlanhaskins lol |
@swift-ci Please python lint |
1 similar comment
@swift-ci Please python lint |
|
6404b93
to
011ab6f
Compare
@swift-ci Please python lint |
@harlanhaskins Thanks! |
Good to merge? |
I lgtm'd this, but I think the code owner for |
Once #1586 is merged, I can merge Linux support. Right now, non-Darwin is guarded inside main.py, but that will be removed once I can lookup |
@modocache @gribozavr Think this is good to merge? |
Hardcoding the xcrun toolchain name is not correct in all cases, but should be a good start. LGTM otherwise. |
Thanks! |
What's in this pull request?
Adds the
-sparse
option to invocations ofllvm-profdata
if it's supported.Abstracts out the lookup for
llvm-profdata
such that it can be replaced if/when #1586 is merged.Resolved bug number: rdar://problem/25072811
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.