[4.2][stdlib] Speed up bridged Dictionary instances #17763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dictionary’s native storage classes and _SwiftDeferredNSDictionary override -[NSDictionary getObjects:andKeys:] instead of its safer replacement, -[NSDictionary getObjects:andKeys:count:]. Overriding the correct method will considerably speed up some Cocoa operations on bridged dictionaries. rdar://problem/39285882 (cherry picked from commit 6aec05a)
… Swift (cherry picked from commit b954e60)
…tionaries (cherry picked from commit 91bb2c0)
(cherry picked from commit a951cf2)
…ndKeys:count: (cherry picked from commit 93ab767)
(cherry picked from commit c7da0f3)
…ementations This breaks out of the loop immediately when the last slot has been filled in the output buffer, skipping a final sequence of iterations over empty buckets. (cherry picked from commit cf7e438)
|
@swift-ci please test |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-picked from #17742.)
Explanation: The bridged representations of native Swift
Dictionaryvalues currently implement a deprecated method inNSDictionary. Implementing the correct funnel leads to a ~5x speedup for certain operations on dictionaries bridged to Objective-C.Scope: Affects dictionary bridging.
Issue: rdar://problem/39285882
Risk: Low. The change observable via the Objective-C runtime; however, this is unlikely to cause issues.
Testing: Standard test suite, including new tests and benchmarks.
Reviewer: @moiseev, @lancep