[Space Engine] Remove the @_downgrade_exhaustivity_check hack #17764
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Good stuff! |
|
Please test with following pull request: @swift-ci Please smoke test Linux platform |
| SIMPLE_DECL_ATTR(_downgrade_exhaustivity_check, DowngradeExhaustivityCheck, | ||
| OnEnumElement | | ||
| LongAttribute | UserInaccessible, | ||
| 71) |
There was a problem hiding this comment.
Can you leave behind a "71 is unused comment" here, like we did for other enums?
Technically this should probably mean bumping the module version too
lib/SILGen/SILGenPattern.cpp
Outdated
| @@ -1812,8 +1812,7 @@ CaseBlocks::CaseBlocks( | |||
| SGF.F.getResilienceExpansion()); | |||
| } | |||
| if (canAssumeExhaustive) { | |||
| // Check that Sema didn't let any cases slip through. (This can happen | |||
| // with @_downgrade_exhaustivity_check.) | |||
| // Check that Sema didn't let any cases slip through. | |||
There was a problem hiding this comment.
I think this can't happen anymore, so maybe we can make this an assertion instead.
CodaFi
force-pushed
the
irreconcilable-spatial-differences
branch
from
0bd059e to
6a93094
Compare
This hack was only needed for Swift 3 mode in a narrow case. Flush it out of the compiler so we can simplify the space engine.
CodaFi
force-pushed
the
irreconcilable-spatial-differences
branch
from
6a93094 to
2fb5afb
Compare
|
Lost the original source compat failure. Let's try again @swift-ci please test source compatibility |
|
Please test with following pull request: @swift-ci Please smoke test |
|
Please test with following pull request: @swift-ci Please smoke test Linux platform |
|
⛵️ |
This hack was only needed for Swift 3 mode in a narrow case. Flush it out of the compiler so we can simplify the space engine.