Enable optional unowned/unowned(unsafe) references #17767
Conversation
|
@swift-ci please smoke test |
davezarzycki
force-pushed
the
enable_opt_unowned_unmanaged
branch
from
8bb93de to
0a6c6f6
Compare
|
@swift-ci please smoke test |
|
This is a big new change (and one that's been requested for a long time, rdar://problem/17277899!). Can you add some execution tests (in test/Interpreter) to show that this is working with both ObjC and non-ObjC types? And can you update CHANGELOG.md? |
John okayed this change in a comment on GitHub pull request: swiftlang#16237
davezarzycki
force-pushed
the
enable_opt_unowned_unmanaged
branch
from
0a6c6f6 to
71472cf
Compare
|
@jrose-apple – Adding the interpreter tests found a bug. So yay for more tests. @swift-ci please test |
|
Build failed |
|
Aack. I hate to delay this even more, but I realized we probably don't want to land it without checking debugger support, or at least a commitment from the debugger folks to add that soon. @dcci, @jimingham, I wouldn't expect this to require any work beyond what we already do for |
|
Hi @jrose-apple – The delay is fine. The ease of this pull request is the result of #16237, which took two months to land, so waiting a few more days isn't a big deal. |
|
@dcci and @jimingham – Ping. Your feedback is appreciated. Thanks! |
|
Sorry, this slipped through the cracks. Reviewing now. |
There was a problem hiding this comment.
@davezarzycki To the. best of my understanding the compiler bits are fine, but I think some work might be needed to get stuffs to work in the debugger. That said, I think it's not worth delaying this PR merge more, so please go ahead.
I think if you're interested you might want to consider adding a REPL tests in lldb for what you added, and then we can go from there. If you don't have time for this, I'd appreciate if you can at least open a bug on JIRA.
|
Thanks @dcci – I have something that might work for lldb. I'll follow up with a pull request. |
@rjmccall okayed this change in a comment on GitHub pull request: #16237