Sema: Check availability of key path components [4.2] #17780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes <https://bugs.swift.org/browse/SR-7406> / <rdar://problem/39319212>.
|
@swift-ci Please test |
|
Build failed |
|
@shahmishal is this a known issue? |
|
@slavapestov I have not seen this failure before. |
|
@swift-ci Please test macOS |
|
Build failed |
|
@shahmishal its non deterministic... |
|
@slavapestov going to disable this test. (41380265) |
|
@swift-ci test macOS |
We would crash in these cases: - If all lookup results were subscripts - If all results were unavailable
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
jckarter
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We weren't checking availability for keypath components. This could result in runtime crashes if you reference selectors that don't exist yet, or linker errors if you reference private things from an inlinable function body.
Origination: This was an issue ever since keypaths were introduced in Swift 4.0.
Tested: New tests added.
Risk: Pretty low, because the availability checking code itself is well-exercised. The main risk is source compatibility issues, but impacted code was not completely valid in the first place anyway.
Bugs: Fixes https://bugs.swift.org/browse/SR-7406 / rdar://problem/39319212.
Reviewed by: @jckarter